From 0e558653360ffe384cd1e3c2c5e7e9e0f5e1a1bc Mon Sep 17 00:00:00 2001
From: Ahmad Farhat <ahmad.af.farhat@gmail.com>
Date: Fri, 23 Jun 2023 11:01:24 -0400
Subject: [PATCH] Scope cache keys to v3 (#5285)
---
app/controllers/api/v1/locales_controller.rb | 2 +-
app/services/provider_credentials.rb | 2 +-
spec/services/provider_credentials_spec.rb | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/controllers/api/v1/locales_controller.rb b/app/controllers/api/v1/locales_controller.rb
index a72d322a..911f2d73 100644
--- a/app/controllers/api/v1/locales_controller.rb
+++ b/app/controllers/api/v1/locales_controller.rb
@@ -25,7 +25,7 @@ module Api
# GET /api/v1/locales
# Returns a cached list of locales available
def index
- language_with_name = Rails.cache.fetch('locales/list', expires_in: 24.hours) do
+ language_with_name = Rails.cache.fetch('v3/locales/list', expires_in: 24.hours) do
language_hash = {}
languages = Dir.entries(Rails.root.join('app/assets/locales')).select { |file_name| file_name.ends_with?('.json') }
diff --git a/app/services/provider_credentials.rb b/app/services/provider_credentials.rb
index 95d58048..6607005d 100644
--- a/app/services/provider_credentials.rb
+++ b/app/services/provider_credentials.rb
@@ -30,7 +30,7 @@ class ProviderCredentials
# Cache the response for an hour
# fetch will return the value if already cached, if not, it will compute the value, cache it, then return it
- Rails.cache.fetch("#{@provider}/#{@route}", expires_in: 1.hour) do
+ Rails.cache.fetch("v3/#{@provider}/#{@route}", expires_in: 1.hour) do
url = URI.parse("#{@endpoint}#{@route}?#{encoded_params}&checksum=#{checksum}")
res = Net::HTTP.get_response(url)
diff --git a/spec/services/provider_credentials_spec.rb b/spec/services/provider_credentials_spec.rb
index c910e0e4..2f3062b5 100644
--- a/spec/services/provider_credentials_spec.rb
+++ b/spec/services/provider_credentials_spec.rb
@@ -61,7 +61,7 @@ describe ProviderCredentials, type: :service do
service.call
expect(service.call).to eq(['https://test.com', 'secret'])
- expect(Rails.cache.read('bbb/getUser')).to eq(['https://test.com', 'secret'])
+ expect(Rails.cache.read('v3/bbb/getUser')).to eq(['https://test.com', 'secret'])
end
end
end
--
GitLab