diff --git a/app/controllers/api/v1/api_controller.rb b/app/controllers/api/v1/api_controller.rb index 502124b701a86aab21001b1bbe732a9c000675b6..92b27351bf055a2950028e5609f9491d0503c2ff 100644 --- a/app/controllers/api/v1/api_controller.rb +++ b/app/controllers/api/v1/api_controller.rb @@ -89,7 +89,7 @@ module Api { sort_column => sort_direction } end - # Checks if external authentication is enabled + # Checks if external authentication is enabled (currently only OIDC is implemented) def external_authn_enabled? ENV['OPENID_CONNECT_ISSUER'].present? end diff --git a/app/controllers/api/v1/env_controller.rb b/app/controllers/api/v1/env_controller.rb index 2541f5ed19ab2b24ba005d995d5bdbd5d61c2095..946e261c2f4510629dd09bf2a59dd0c9c32b86b4 100644 --- a/app/controllers/api/v1/env_controller.rb +++ b/app/controllers/api/v1/env_controller.rb @@ -25,7 +25,7 @@ module Api # Returns basic NON-CONFIDENTIAL information on the environment variables def index render_data data: { - OPENID_CONNECT: ENV['OPENID_CONNECT_ISSUER'].present?, + EXTERNAL_AUTH: ENV['OPENID_CONNECT_ISSUER'].present?, # currently only OIDC is implemented HCAPTCHA_KEY: ENV.fetch('HCAPTCHA_SITE_KEY', nil), VERSION_TAG: ENV.fetch('VERSION_TAG', ''), CURRENT_PROVIDER: current_provider, diff --git a/app/javascript/components/admin/manage_users/ManageUsers.jsx b/app/javascript/components/admin/manage_users/ManageUsers.jsx index c72d9eef3b67c0272b41080bae8f9422c743b7c3..b8269617b1e9f1d585ba6a092c8884a710efd78c 100644 --- a/app/javascript/components/admin/manage_users/ManageUsers.jsx +++ b/app/javascript/components/admin/manage_users/ManageUsers.jsx @@ -81,7 +81,7 @@ export default function ManageUsers() { /> )} { - (!envAPI.isLoading && !envAPI.data?.OPENID_CONNECT) + (!envAPI.isLoading && !envAPI.data?.EXTERNAL_AUTH) && ( <Modal modalButton={ diff --git a/app/javascript/components/admin/site_settings/registration/Registration.jsx b/app/javascript/components/admin/site_settings/registration/Registration.jsx index 3c2e2edbbe25ef58594c27a98daf2ef3be5e6936..6b75f888bcf91952c6ad00472c7e5d424dc47f27 100644 --- a/app/javascript/components/admin/site_settings/registration/Registration.jsx +++ b/app/javascript/components/admin/site_settings/registration/Registration.jsx @@ -52,7 +52,7 @@ export default function Registration() { </Dropdown.Item> </SettingSelect> - { env?.OPENID_CONNECT && ( + { env?.EXTERNAL_AUTH && ( <Row className="mb-3"> <SettingsRow name="ResyncOnLogin" diff --git a/app/javascript/components/home/AuthButtons.jsx b/app/javascript/components/home/AuthButtons.jsx index 3bb4a3201142659134e737e412983cdbf2ef428e..b088fb64a272f47b12a1f4c29f9fc90f685366af 100644 --- a/app/javascript/components/home/AuthButtons.jsx +++ b/app/javascript/components/home/AuthButtons.jsx @@ -40,7 +40,7 @@ export default function AuthButtons({ direction }) { return registrationMethod !== 'invite' || !!inviteToken; } - if (env?.OPENID_CONNECT) { + if (env?.EXTERNAL_AUTH) { return ( <Form action={process.env.OMNIAUTH_PATH} method="POST" data-turbo="false"> <input type="hidden" name="authenticity_token" value={document.querySelector('meta[name="csrf-token"]').content} /> diff --git a/app/javascript/components/rooms/room/join/JoinCard.jsx b/app/javascript/components/rooms/room/join/JoinCard.jsx index 41ac6ac491ab96308e998ebeaa143d91d220910a..73fc255feb200814174c476e8925eae2168bd554 100644 --- a/app/javascript/components/rooms/room/join/JoinCard.jsx +++ b/app/javascript/components/rooms/room/join/JoinCard.jsx @@ -252,7 +252,7 @@ export default function JoinCard() { </Row> <Row> {!currentUser?.signed_in && ( - env?.OPENID_CONNECT ? ( + env?.EXTERNAL_AUTH ? ( <Stack direction="horizontal" className="d-flex justify-content-center text-muted mt-3"> {t('authentication.already_have_account')} <RegularForm action={process.env.OMNIAUTH_PATH} method="POST" data-turbo="false"> <input type="hidden" name="authenticity_token" value={document.querySelector('meta[name="csrf-token"]').content} /> diff --git a/app/javascript/components/rooms/room/join/RequireAuthentication.jsx b/app/javascript/components/rooms/room/join/RequireAuthentication.jsx index 98ed8676e09555ed0789bb35c0d45794ad25801d..88908ddcf0eb1f3470bed6b5f7be07cc0a7ff256 100644 --- a/app/javascript/components/rooms/room/join/RequireAuthentication.jsx +++ b/app/javascript/components/rooms/room/join/RequireAuthentication.jsx @@ -38,7 +38,7 @@ export default function RequireAuthentication({ path }) { </Card.Body> <Card.Footer className="bg-white"> { - env?.OPENID_CONNECT ? ( + env?.EXTERNAL_AUTH ? ( <Form action={process.env.OMNIAUTH_PATH} method="POST" data-turbo="false"> <input type="hidden" name="authenticity_token" value={document.querySelector('meta[name="csrf-token"]').content} /> <Button variant="brand-outline-color" className="btn btn-lg m-2" type="submit">{t('authentication.sign_up')}</Button> diff --git a/app/javascript/components/users/authentication/Signup.jsx b/app/javascript/components/users/authentication/Signup.jsx index b5306175dc5447a18e874738d9c5e3fd6577be28..7cbe8b3aa651e67b7d2fc92f4642f672c2bd452f 100644 --- a/app/javascript/components/users/authentication/Signup.jsx +++ b/app/javascript/components/users/authentication/Signup.jsx @@ -32,7 +32,7 @@ export default function Signup() { const envAPI = useEnv(); const isLoading = envAPI.isLoading || registrationMethodSettingAPI.isLoading; - if (envAPI.data?.OPENID_CONNECT) { + if (envAPI.data?.EXTERNAL_AUTH) { return <Navigate to="/" replace />; } diff --git a/esbuild.dev.mjs b/esbuild.dev.mjs index 1bd3839ca45e3ce4c263ede547139a67727ef6a7..3ff73114056374516d1a4f52d55fe7386dc34128 100644 --- a/esbuild.dev.mjs +++ b/esbuild.dev.mjs @@ -20,7 +20,7 @@ await esbuild.build({ }, define: { 'process.env.RELATIVE_URL_ROOT': `"${relativeUrlRoot}"`, - 'process.env.OMNIAUTH_PATH': `"${relativeUrlRoot}/auth/openid_connect"`, + 'process.env.OMNIAUTH_PATH': `"${relativeUrlRoot}/auth/openid_connect"`, // currently, only OIDC is implemented }, }); diff --git a/esbuild.mjs b/esbuild.mjs index 6330cbc21df5b365c17d67fc364ac2eae4b8bce6..e9aa8a45e199ad458622ef3711a9bd6618f584f8 100644 --- a/esbuild.mjs +++ b/esbuild.mjs @@ -14,7 +14,7 @@ await esbuild.build({ }, define: { 'process.env.RELATIVE_URL_ROOT': `"${relativeUrlRoot}"`, - 'process.env.OMNIAUTH_PATH': `"${relativeUrlRoot}/auth/openid_connect"`, + 'process.env.OMNIAUTH_PATH': `"${relativeUrlRoot}/auth/openid_connect"`, // currently, only OIDC is implemented }, });