Forgive copy-pasting CLs

tf_oss_dashboard/script.js

@@ -105,7 +105,11 @@ $(function () {
   // If the hash is exactly 41 chars (hash sign # plus a 40-char sha hash),
   // just show that modal.
   } else if (window.location.hash.length == 41) {
+    if ($(window.location.hash).length) {
       new bootstrap.Modal(window.location.hash).show()
+    } else {
+      new bootstrap.Modal("#tf-no-commit-modal").show()
+    }
   // And if it's not a commit sha, it's either a PR or a CL, so try and find a
   // modal matching that PR number if the length is short (CLs will always
   // be nine or more characters)
@@ -114,13 +118,21 @@ $(function () {
       return $(this).text().indexOf("Merge pull request " + window.location.hash) >= 0;
     })
     const modal_id = "#" + pr.closest(".modal").attr('id')
+    if ($(modal_id).length) {
       new bootstrap.Modal(modal_id).show()
+    } else {
+      new bootstrap.Modal("#tf-no-pr-modal").show()
+    }
   // And if it's neither, it's a CL, so try and find a modal
   // matching that CL number
   } else {
     const cl = window.location.hash.substring(1).replace("cl/", "")
     const modal_id = '#' + $(`.modal[data-cl=${cl}]`).attr('id')
+    if ($(modal_id).length) {
       new bootstrap.Modal(modal_id).show()
+    } else {
+      new bootstrap.Modal("#tf-no-cl-modal").show()
+    }
   }
 
   let revealed = null

tf_oss_dashboard/template.html.pug

@@ -122,3 +122,18 @@ html(lang="en")
         .modal-content
           .modal-header.fw-bold Dashboard Help
           .modal-body !{helptext}
+    .modal.modal-lg.fade(tabindex='-1' aria-labelledby="tf-no-cl-modal" id="tf-no-cl-modal" aria-hidden='true')
+      .modal-dialog.modal-dialog-centered
+        .modal-content
+          .modal-header.fw-bold CL Not Found
+          .modal-body Sorry, that CL isn't on the dashboard. If new, it may not be on GitHub yet, or may not have any CI results yet. If it's an older CL, it may be old enough that the data window no longer includes it. The dashboard only displays the last one thousand TF commits, which is usually about two weeks of commits.
+    .modal.modal-lg.fade(tabindex='-1' aria-labelledby="tf-no-commit-modal" id="tf-no-commit-modal" aria-hidden='true')
+      .modal-dialog.modal-dialog-centered
+        .modal-content
+          .modal-header.fw-bold Commit Not Found
+          .modal-body Sorry, that commit isn't on the dashboard. If new, it may not have any CI results yet. If it's an older commit, it may be old enough that the data window no longer includes it. The dashboard only displays the last one thousand TF commits, which is usually about two weeks of commits.
+    .modal.modal-lg.fade(tabindex='-1' aria-labelledby="tf-no-pr-modal" id="tf-no-pr-modal" aria-hidden='true')
+      .modal-dialog.modal-dialog-centered
+        .modal-content
+          .modal-header.fw-bold PR Not Found
+          .modal-body Sorry, that PR isn't on the dashboard. If new, it may not have any CI results yet, or may not be merged yet. If it's an older PR, it may be old enough that the data window no longer includes it. The dashboard only displays the last one thousand TF commits, which is usually about two weeks of commits.