Revert hiding recording menus when recording disabled (#1959)

app/views/rooms/components/_room_event.html.erb

@@ -40,7 +40,6 @@
   </div>
 </div>
 
-<% recording = room_configuration("Room Configuration Recording") %>
-<% if render_recordings && recording != "disabled" %>
+<% if render_recordings %>
   <%= render "shared/sessions", recordings: @public_recordings, pagy: @pagy, only_public: true, user_recordings: false, title: t("room.recordings") %>
 <% end %>

app/views/rooms/show.html.erb

@@ -103,10 +103,7 @@
   </div>
 </div>
 
-<% recording = room_configuration("Room Configuration Recording") %>
-<% if recording != "disabled" %>
 <%= render "shared/sessions", recordings: @recordings, pagy: @pagy, only_public: false, shared_room: @shared_room, user_recordings: false, title: t("room.recordings")%>
-<% end %>
 
 <%= render "shared/modals/delete_room_modal" %>
 

app/views/shared/_header.html.erb

@@ -31,9 +31,7 @@
             <i class="fas fa-home pr-1 "></i><span class="d-none d-sm-inline-block"><%= t("header.dropdown.home") %></span>
           <% end %>
 
-          <% recording = room_configuration("Room Configuration Recording") %>
-          <% if current_user.role.get_permission("can_create_rooms") && !current_user.has_role?(:super_admin) &&
-            recording != "disabled" %>
+          <% if current_user.role.get_permission("can_create_rooms") && !current_user.has_role?(:super_admin) %>
             <% all_rec_page = params[:controller] == "users" && params[:action] == "recordings" ? "active" : "" %>
             <%= link_to get_user_recordings_path(current_user), class: "px-3 mx-1 mt-1 header-nav #{all_rec_page}" do %>
               <i class="fas fa-video pr-1"></i><span class="d-none d-sm-inline-block"><%= t("header.all_recordings") %></span>