GRN-80: Patch for fixing the added function in a production environment (#444)

* Patch for fixing the added function in a production environment

* Rubocop!

app/helpers/application_helper.rb

@@ -76,12 +76,16 @@ module ApplicationHelper
   end
 
   def allow_greenlight_accounts?
-    return true unless Rails.configuration.loadbalanced_configuration
+    return Rails.configuration.allow_user_signup unless Rails.configuration.loadbalanced_configuration
     return false unless Rails.configuration.allow_user_signup
     # No need to retrieve the provider info if the provider is whitelisted
     return true if launcher_allow_user_signup_whitelisted?(@user_domain)
     # Proceed with retrieving the provider info
+    begin
       provider_info = retrieve_provider_info(@user_domain, 'api2', 'getUserGreenlightCredentials')
       provider_info['provider'] == 'greenlight'
+    rescue
+      false
+    end
   end
 end

app/views/shared/_header.html.erb

@@ -56,15 +56,16 @@
 						</div>
 					</div>
         <% else %>
+          <% allow_greenlight_accounts = allow_greenlight_accounts? %>
           <% if Rails.configuration.omniauth_ldap %>
             <%= link_to t("login"), omniauth_login_url(:ldap), :class => "btn btn-pill btn-outline-primary mx-2" %>
-          <% elsif allow_greenlight_accounts? %>
+          <% elsif allow_greenlight_accounts %>
             <%= link_to t("login"), "#loginModal", :class => "btn btn-pill btn-outline-primary mx-2", "data-toggle": "modal" %>
           <% else %>
             <%= link_to t("login"), omniauth_login_url(:bn_launcher), :class => "btn btn-pill btn-outline-primary mx-2" %>
           <% end %>
 
-          <% if allow_user_signup? && allow_greenlight_accounts? %>
+          <% if allow_user_signup? && allow_greenlight_accounts %>
             <%= link_to t("signup.title"), signup_path, :class => "btn btn-pill btn-outline-primary mx-2" %>
           <% end %>